chore: clean code

formancehq · Oct 23, 2024 · 0143068 · 0143068
1 parent eefd452
commit 0143068
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/internal/api/v2/controllers_ledgers_list_test.go b/internal/api/v2/controllers_ledgers_list_test.go
@@ -40,8 +40,8 @@ func TestListLedgers(t *testing.T) {
 			name:        "nominal",
 			expectQuery: ledgercontroller.NewListLedgersQuery(15),
 			returnData: []ledger.Ledger{
-				ledger.Must(ledger.NewWithDefaults(uuid.NewString())),
-				ledger.Must(ledger.NewWithDefaults(uuid.NewString())),
+				ledger.MustNewWithDefault(uuid.NewString()),
+				ledger.MustNewWithDefault(uuid.NewString()),
 			},
 			expectBackendCall: true,
 		},

diff --git a/internal/controller/ledger/stats_test.go b/internal/controller/ledger/stats_test.go
@@ -25,7 +25,7 @@ func TestStats(t *testing.T) {
 		Return(10, nil)
 
 	ledgerController := NewDefaultController(
-		ledger.Must(ledger.NewWithDefaults("foo")),
+		ledger.MustNewWithDefault("foo"),
 		store,
 		NewMockListener(ctrl),
 		machineFactory,

diff --git a/internal/ledger.go b/internal/ledger.go
@@ -157,10 +157,10 @@ func NewWithDefaults(name string) (*Ledger, error) {
 	return New(name, NewDefaultConfiguration())
 }
 
-// todo(libs): move in shared libs
-func Must[V any](v *V, err error) V {
+func MustNewWithDefault(name string) Ledger {
+	ledger, err := New(name, NewDefaultConfiguration())
 	if err != nil {
 		panic(err)
 	}
-	return *v
-}
+	return *ledger
+}
diff --git a/internal/storage/ledger/main_test.go b/internal/storage/ledger/main_test.go
@@ -80,7 +80,7 @@ func newLedgerStore(t T) *Store {
 
 	require.NoError(t, systemstore.Migrate(ctx, db))
 
-	l := ledger.Must(ledger.NewWithDefaults(ledgerName))
+	l := ledger.MustNewWithDefault(ledgerName)
 	l.Bucket = ledgerName
 
 	b := bucket.New(db, ledgerName)