Caches consts #221
Merged
Caches consts #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
filipeom
commented
Oct 3, 2024
•
filipeom
commented
|
@joaomhmpereira I've set cvc5's EDIT: I reverted it as it was not passing the CI. |
filipeom
force-pushed
the
caches-consts
branch
from
90c7f12 to
d17e202
Compare
Solvers can inform us that they cache constants by setting the flag `caches_consts = true` in their mappings. This should avoid having a `Map.find_opt` everytime we call `make_symbol`. Currently the mappings that behave like this are only Z3
filipeom
force-pushed
the
caches-consts
branch
from
d17e202 to
3a372f5
Compare
|
Queueing to merge. We can set cvc5's caches_const to true in another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.