Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare version 1.2.0 #27

Merged
merged 14 commits into from
Sep 9, 2024
Merged

Prepare version 1.2.0 #27

merged 14 commits into from
Sep 9, 2024

Conversation

joaomhmpereira
Copy link
Member

Update the version of cvc5 supported by the bindings to v1.2.0

@filipeom
Copy link
Member

filipeom commented Aug 20, 2024

This fixes the compare_pointer warning I was getting with the version in opam, but now I also get:

File "bin/dune", line 2, characters 7-11:
2 |  (name main)
           ^^^^
/usr/bin/ld: /home/filipe/.local/share/opam/ocaml-variants.5.2.0+options/lib/cvc5/libcvc5.a(cadical.cpp.o): in function `cvc5::internal::prop::CadicalSolver::getProofSketch()':
cadical.cpp:(.text+0x4de): undefined reference to `CaDiCaL::Solver::flush_proof_trace(bool)'
collect2: error: ld returned 1 exit status
File "caml_startup", line 1:
Error: Error during linking (exit code 1)

When trying to compile smtml with this version. Do you know anything about it? (this is #19, which seems to have come back)

@joaomhmpereira
Copy link
Member Author

This should fix it. @filipeom can you check it? (I can't reproduce the error)

@filipeom
Copy link
Member

filipeom commented Aug 21, 2024

This should fix it. @filipeom can you check it? (I can't reproduce the error)

In the smtml CI it seems to build fine, I'm only experiencing these issues locally with ocaml 5.2.0. And the CI runs 5.1, so there might be an issue there?

@filipeom
Copy link
Member

Confirm, it seems to only happen on 5.2

@joaomhmpereira joaomhmpereira linked an issue Sep 9, 2024 that may be closed by this pull request
@joaomhmpereira joaomhmpereira merged commit a981f30 into main Sep 9, 2024
2 checks passed
@joaomhmpereira joaomhmpereira deleted the prepare-1.2.0 branch September 9, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation to module interfaces
2 participants