Fix build #807
Open
Fix build #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -285,11 +286,12 @@ var getOptions = cli.getOptions = function (file) { | |||
|
|
|||
| if (configs && configs.length) { | |||
| return configs.map(function (conf) { | |||
| return assignSpawnWith(objectAssign(clone(options), conf)); | |||
| var startupConfig = setDefaults(objectAssign(clone(options), conf)); | |||
There was a problem hiding this comment.
not sure why this is correct btw - this gives config values higher priority than cli flags. Surely this should be reversed?
|
@macobo Is this still relevant? What was broken about the build? |
|
@kibertoad Not sure; I think I was trying to build from source years ago and ran into this issue. If everything is stable, feel free to close this PR. |
|
Thank you for clarification! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason the test suite needs to have cwd set to root dir. This needs to be explicit because of some change some other PR made.