Winston log integration and log rotation features #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit uses Winston logging for forever logFile, outFile and errFile. It's possible to use the log rotation features of winston (see tailable, maxsize, maxFiles and zippedArchive options). See foreversd/forever#128 Note that log rotation for the logFile will not work if the spawner of this process (forever) has provided a file descriptor for stdout and stderr, those values must be setted to 'ignore' and will be subject of a PR to the forever repository
Fix failed test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses Winston logging for forever logFile, outFile and
errFile. It's possible to use the log rotation features of winston (see
tailable, maxsize, maxFiles and zippedArchive options).
See foreversd/forever#128
Note that log rotation for the logFile will not work if the spawner of
this process (forever) has provided a file descriptor for stdout and
stderr, those values must be setted to 'ignore' and will be subject of a
PR to the forever repository