Refactor: no need to pass through the ahoy event name dynamically. #18498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ridhwana
requested review from
jaw6 and
fdocr
and removed request for
a team
fdocr
approved these changes
Sep 26, 2022
jaw6
approved these changes
Sep 27, 2022
jaw6
added a commit
that referenced
this pull request
Oct 3, 2022
…_tracking_rollup * origin/main: Remove featured_number from articles table (#18514) Snackbar error message in comments image upload (#18504) Restore DisplayAd search (#18511) Update strong_migrations to version 1.3.1 (#18516) Refactor: no need to pass through the ahoy event name dynamically. (#18498) Remove featured number usage from articles (#18510) [ruby] Update sidekiq: 6.5.6 → 6.5.7 (patch) (#18507) Update recaptcha to version 5.12.3 (#18506) Update octokit to version 5.6.1 (#18505) Feed experiment for 09-26-2022 (#18501) Update all Yarn dependencies (2022-09-26) (#18497)
TERNOX
pushed a commit
to TERNOX/forem-bezmir
that referenced
this pull request
Oct 7, 2022
…orem#18498) * refactor: the name does not need to be passed through dynamically * refactor: the name does not need to be passed through dynamically * chore: remove name from the js doc
TERNOX
pushed a commit
to TERNOX/forem-bezmir
that referenced
this pull request
Jan 5, 2025
…orem#18498) * refactor: the name does not need to be passed through dynamically * refactor: the name does not need to be passed through dynamically * chore: remove name from the js doc
TERNOX
pushed a commit
to TERNOX/forem-bezmir
that referenced
this pull request
Jan 5, 2025
…orem#18498) * refactor: the name does not need to be passed through dynamically * refactor: the name does not need to be passed through dynamically * chore: remove name from the js doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Currently, we pass through the Ahoy Event name but we have specific functions for each event because each one has a unique structure. Hence, we do not need to pass through the name dynamically.
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
UI accessibility concerns?
If your PR includes UI changes, please replace this line with details on how
accessibility is impacted and tested. For more info, check out the
Forem Accessibility Docs.
Added/updated tests?
[Forem core team only] How will this change be communicated?
Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.
Storybook (for Crayons components)
updated. I have filled out the
Changes Requested
issue template so Community Success can help update the Admin Docs
appropriately.
CHANGELOG.mdor in a forem.dev post
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?