perf: early exit for pathIsInfolder (19% faster) #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukecotter
changed the title
Will now pre process filePaths and group them by their packagedirectory. This prevents the same file being checked for inclusion in a directory when it has already been included in a previous directory.
|
hi @lukecotter thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
pathIsInfolder will exit as early as possible,.
This improved overall
sf project deploy starttimes in my project by ~19%What issues does this PR fix or reference?
Combined with this pull request in isomorphic git I was seeing roughly 45 - 50% faster times working out the changed files to deploy.
If it is accepted it would be great to upgrade that too.
Do you want me to create an issue on the issues repo?