Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate manifests #996

Merged
merged 1 commit into from
Jun 5, 2023
Merged

feat: validate manifests #996

merged 1 commit into from
Jun 5, 2023

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented May 31, 2023

What does this PR do?

validate manifests are valid xml

What issues does this PR fix or reference?

@W-13505922@

Functionality Before

successfully wrote package.xml (but ignored invalid types)

Functionality After

Error (1): Invalid manifest file: package.xml.
InvalidTag Tag '<types' is an invalid name. (Line 3 Column 12)

@mshanemc mshanemc requested a review from a team as a code owner May 31, 2023 18:59
@iowillhoit
Copy link
Contributor

QA NOTES

  • 🟢 Convert warns of invalid manifest <<types>
  • 🟢 Convert warns of invalid manifest <types>>
  • 🟡 Oddly this is valid xml? ><types>? No warning and everything converts correctly 🤷
    • So is <types>>?
  • 🟢 Considers xml comments valid <members>FileUtilities<!-- comment --></members>
  • 🟢 Considers extra newlines valid
</types>

    <version>57.0</version>
</Package>
  • 🟢 project deploy start -x package.xml warns of invalid manifest
  • 🟢 project retrieve start -x package.xml warns of invalid manifest
  • 🟢 Nice message about missing a closing tag InvalidTag: Expected closing tag 'types
  • 🟢 Convert, deploy, and retrieve all still work as expected with valid xml

@iowillhoit iowillhoit merged commit 173aba7 into main Jun 5, 2023
@iowillhoit iowillhoit deleted the sm/validate-manifests branch June 5, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants