Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sm/qa pr 900 new branch #911

Merged
merged 27 commits into from
Mar 29, 2023
Merged

Sm/qa pr 900 new branch #911

merged 27 commits into from
Mar 29, 2023

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

QA changes for DEB

What issues does this PR fix or reference?

@W-12749906@
forcedotcom/cli#2014

@mshanemc mshanemc requested a review from a team as a code owner March 28, 2023 22:21
@mshanemc
Copy link
Contributor Author

mshanemc commented Mar 28, 2023

QA notes: done with DEB author. 1 NUT will fail until test changes from salesforcecli/plugin-source#789 merge.

proof of correctness: https://github.com/forcedotcom/source-deploy-retrieve/actions/runs/4548504479 (ran against the PR on plugin-source)

fixed filepaths from win-specialTypes with this commit: salesforcecli/plugin-source@39ef05f

which reran to produce https://github.com/forcedotcom/source-deploy-retrieve/actions/runs/4548504479

mshanemc and others added 7 commits March 28, 2023 18:12
# Conflicts:
#	test/nuts/perfResults/x64-linux-2xIntel-Xeon-Platinum-8171M-CPU-2-60GHz/eda.json
#	test/nuts/perfResults/x64-linux-2xIntel-Xeon-Platinum-8171M-CPU-2-60GHz/lotsOfClasses.json
#	test/nuts/perfResults/x64-linux-2xIntel-Xeon-Platinum-8171M-CPU-2-60GHz/lotsOfClassesOneDir.json
@mshanemc
Copy link
Contributor Author

ran this from the plugin with yarn link and the failing test was ok

@mshanemc mshanemc merged commit 1511388 into main Mar 29, 2023
@mshanemc mshanemc deleted the sm/qa-pr-900-new-branch branch March 29, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants