Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only emit events once per lifecycle #825

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Conversation

WillieRuemmele
Copy link
Member

What does this PR do?

only emits the "beyond max api version" event once to prevent

 ➜  sfdx force:source:deploy -p force-app --apiversion=57.0 
(node:71680) Warning: The requested API version (57.0) is higher than the org supports.  Using 56.0.
(Use `node --trace-warnings ...` to show where the warning was created)
Deploying v55.0 metadata to [email protected] using the v56.0 SOAP API
Deploy ID: 0Af8G00000UQfwNSAT
(node:71680) Warning: The requested API version (57.0) is higher than the org supports.  Using 56.0.
(node:71680) Warning: The requested API version (57.0) is higher than the org supports.  Using 56.0.
DEPLOY PROGRESS | ███░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░ | 6/89 Components(node:71680) Warning: The requested API version (57.0) is higher than the org supports.  Using 56.0.
(node:71680) Warning: The requested API version (57.0) is higher than the org supports.  Using 56.0.
(node:71680) Warning: The requested API version (57.0) is higher than the org supports.  Using 56.0.
(node:71680) Warning: The requested API version (57.0) is higher than the org supports.  Using 56.0.
(node:71680) Warning: The requested API version (57.0) is higher than the org supports.  Using 56.0.

What issues does this PR fix or reference?

#forcedotcom/cli#1878, @W-12375309@

Functionality After

 ➜  sfdx force:source:deploy -p force-app --apiversion=57.0 
(node:71680) Warning: The requested API version (57.0) is higher than the org supports.  Using 56.0.
(Use `node --trace-warnings ...` to show where the warning was created)

@WillieRuemmele WillieRuemmele requested review from a team as code owners January 19, 2023 23:20
@shetzel
Copy link
Contributor

shetzel commented Jan 20, 2023

Tested with the https://github.com/salesforcecli/sample-project-multiple-packages project and the command:
sfdx force:source:deploy -p force-app,my-app,foo-bar --apiversion 58.0

Outputs once as desired.

@mshanemc mshanemc merged commit 22324bd into main Jan 20, 2023
@mshanemc mshanemc deleted the wr/multipleEventsEmitted branch January 20, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants