Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: await SVS promises to write to manifest #824

Merged
merged 2 commits into from
Jan 20, 2023
Merged

fix: await SVS promises to write to manifest #824

merged 2 commits into from
Jan 20, 2023

Conversation

WillieRuemmele
Copy link
Member

What does this PR do?

fixes creating a manifest with StandardValueSets

What issues does this PR fix or reference?

#, @W-12402176@

Functionality Before

source:manifest:generate --fromorg wouldn't add StandardValueSet metadata to the manifest

Functionality After

STandardValueSet metadata is in the manifest

@WillieRuemmele WillieRuemmele requested review from a team as code owners January 18, 2023 23:49
@shetzel
Copy link
Contributor

shetzel commented Jan 20, 2023

I tested running sfdx force:source:manifest:create --fromorg testorg 5 times and every time it wrote StandardValueSet. 👍

@mshanemc mshanemc merged commit 02895e2 into main Jan 20, 2023
@mshanemc mshanemc deleted the wr/standardValueSet branch January 20, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shetzel shetzel shetzel approved these changes

@CristiCanizales CristiCanizales Awaiting requested review from CristiCanizales CristiCanizales was automatically assigned from forcedotcom/ide-experience

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@WillieRuemmele @shetzel @mshanemc @svc-cli-bot