Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include string errors during convert #781

Merged
merged 4 commits into from
Nov 22, 2022

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Nov 22, 2022

What does this PR do?

Adds the error message to the new error when the caught error is a String.

What issues does this PR fix or reference?

forcedotcom/cli#1420
@W-12099973@

Functionality Before

sfdx force:source:deploy -p force-app/main/default/classes/PagedResult.cls
*** Deploying with SOAP API v56.0 ***
ERROR running force:source:deploy:  Component conversion failed: undefined

Functionality After

sfdx force:source:deploy -p force-app/main/default/classes/PagedResult.cls
*** Deploying with SOAP API v56.0 ***
ERROR running force:source:deploy:  Component conversion failed: error converting stream - Error: ENOENT: no such file or directory, open '.../ebikes-lwc/force-app/main/default/classes/PagedResult.cls-meta.xml'

@shetzel shetzel requested review from a team as code owners November 22, 2022 00:21
@shetzel shetzel requested a review from RitamAgrawal November 22, 2022 00:21
@mshanemc
Copy link
Contributor

QA:

✅ looks exactly like the PR says it does.

note: the absence of a meta file, when deploying a whole folder or project, just omits the file from the deployment.

@mshanemc mshanemc merged commit 2f10c45 into main Nov 22, 2022
@mshanemc mshanemc deleted the sh/better-conversion-error-handling branch November 22, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants