Sm/archiver-bug #768
Merged
Sm/archiver-bug #768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
commented
Nov 11, 2022
| @@ -408,7 +408,11 @@ export class MetadataApiDeploy extends MetadataTransfer<MetadataApiDeployStatus, | |||
| const zip = createArchive('zip', { zlib: { level: 9 } }); | |||
| // anywhere not at the root level is fine | |||
| zip.directory(this.options.mdapiPath, 'zip'); | |||
| await zip.finalize(); | |||
There was a problem hiding this comment.
this was changed in here https://github.com/forcedotcom/source-deploy-retrieve/pull/748/files#diff-241374a8e829853ad35d675aec9a8689aa15caa58582f8270c9e4c3de08e3aecL390
the linter/types are unreliable.
mshanemc
commented
Nov 11, 2022
gbockus-sf
reviewed
Nov 11, 2022
| // the typings on it are misleading and unintended. More info https://github.com/archiverjs/node-archiver/issues/476 | ||
| // If you await it, bad things happen, like the convert process exiting silently. https://github.com/forcedotcom/cli/issues/1791 | ||
| // leave the void as it is | ||
| void zip.finalize(); |
There was a problem hiding this comment.
It's a shame gifs don't work in github comments
RodEsp
approved these changes
Nov 11, 2022
WillieRuemmele
approved these changes
Nov 11, 2022
QAI Results look good ✔️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
don't await for archiver. See comments for explanation
What issues does this PR fix or reference?
@W-12050345@ forcedotcom/cli#1802
QA/Repro
use https://github.com/mshanemc/nestedFolders, then switch to the sdr-768 branch.
it's already got a mdapiOut folder with an email template which contains a very, very large attachment (as suggested by the customer on forcedotcom/cli#1802
create an org
yarn link SDR into plugin-source, then
../../plugin-source/bin/dev force:mdapi:deploy --deploydir mdapiOut --checkonly --jsonyou'll see the sfdx version of the command silently exit, but the version with this SDR branch works as expected.