Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle namespaces on lwc markup #669

Merged
merged 4 commits into from
Jul 21, 2022
Merged

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

remove custom (non c:) namespaces from componentFailures in the workaround code

What issues does this PR fix or reference?

forcedotcom/cli#1602
@W-11385290@

Functionality Before

reported failed LWC deployments as successes if there was a custom namespace.

@mshanemc mshanemc requested review from a team as code owners July 21, 2022 15:08
@mshanemc mshanemc requested a review from jeffb-sfdc July 21, 2022 15:08
Copy link

@randi274 randi274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward enough! Is it worth updating tests as well @mshanemc?

@mshanemc
Copy link
Contributor Author

Looks straightforward enough! Is it worth updating tests as well @mshanemc?

I did. You're not the first person to ask 😄

Copy link

@randi274 randi274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once the tests are passing 👍

@mshanemc mshanemc merged commit 8817545 into main Jul 21, 2022
@mshanemc mshanemc deleted the sm/file-responses-lwc-bug branch July 21, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants