Sm/timeout id in sfdx error #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
shetzel
approved these changes
Apr 21, 2022
|
The failing NUTs passed locally when I ran them. Manual testing looked good as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
throws an sfdxError with data property for id on timeout.
I'm making a separate WI for SDR to use error/messages from core rather than its own framework.
What issues does this PR fix or reference?
@W-10978703@
for QA...SDR is emitting error.code 1 for backward compatibility. I think the logic on plugin-source should set incompletes to 69 based on the mdapi status...but that's worth verifying