Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sh/parse cdata #607

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Sh/parse cdata #607

merged 3 commits into from
Apr 7, 2022

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Apr 5, 2022

What does this PR do?

Allows metadata files containing CDATA to be deployed.

What issues does this PR fix or reference?

forcedotcom/cli#1467
@W-10946208@

@shetzel shetzel requested review from a team as code owners April 5, 2022 23:28
@shetzel shetzel requested a review from gbockus-sf April 5, 2022 23:28
@WillieRuemmele
Copy link
Member

QA:
Before:

Type   Name          Problem
─────  ────────────  ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
Error  CustomLabels  Error parsing file: Unexpected element {http://soap.sforce.com/2006/04/metadata}p during simple type deserialization (8:19)

ERROR running force:source:deploy:  Deploy failed.

AFTER:
✅ : source:deploy
✅ : source:retrieve
✅ : source:pull
✅ : source:push
✅ : source:convert -> mdapi:beta:deploy

@shetzel shetzel merged commit 178fc3f into main Apr 7, 2022
@shetzel shetzel deleted the sh/parse-cdata branch April 7, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants