Sm/tweaks fp #577
Merged
Sm/tweaks fp #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
approved these changes
Feb 15, 2022
mshanemc
added a commit
that referenced
this pull request
Feb 15, 2022
* chore: initial cleanup, average lower, still spikes to 3GB * chore: staticresource unzip now pipelined asap * chore: add UTs * chore: revert some changes from global pipeline effort * Sm/tweaks fp (#577) * perf: promise.all the pipelining * test: equal in any order * chore: adding types for SDR Co-authored-by: Shane McLaughlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Begins writing StaticResource files as soon as possible, rather than deferring them to the WriteInfos and finalizers
What issues does this PR fix or reference?
forcedotcom/cli#1348, @W-10417338@
Functionality Before
A large spike in memory usage as SDR writes all SR files, up to 3GB but really unrestricted
Functionality After
no spike in memory usage when writing SR files
QA helpful notes:
clone the repo mentioned in the issue
open activity monitory
deploy everything in the project to a new SO
retrieve -m StaticResource while looking at activity monitory
notice huge spike in the memory right before it prints the table, the spinner even slows down