Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure component.content is always assigned #485

Merged
merged 6 commits into from
Oct 28, 2021
Merged

fix: ensure component.content is always assigned #485

merged 6 commits into from
Oct 28, 2021

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Oct 27, 2021

What does this PR do?

Properly resolves CustomFieldTranslation from a retrieve without the source files in a ComponentSet.

What issues does this PR fix or reference?

@W-10028547@

Functionality Before

Would throw and error about an invalid child component encountered

Functionality After

retrieves the CustomFieldTranslation

@shetzel shetzel requested review from a team as code owners October 27, 2021 22:26
@shetzel shetzel requested a review from xyc October 27, 2021 22:26
@WillieRuemmele
Copy link
Member

QA:

Using Cristian's repo I was able to retrieve as many times as I waned and it worked, with or without existing metadata

using Eric's repo I was able to convert CustomFieldTranslations correctly still,

this fixes the new bug, and maintains behavior with the old fix

@WillieRuemmele WillieRuemmele merged commit d77f475 into main Oct 28, 2021
@WillieRuemmele WillieRuemmele deleted the sh/CustomFieldTranslation-fix branch October 28, 2021 19:29
@WillieRuemmele WillieRuemmele mentioned this pull request Oct 28, 2021
Closed
@WillieRuemmele WillieRuemmele mentioned this pull request Nov 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillieRuemmele WillieRuemmele WillieRuemmele approved these changes

@mshanemc mshanemc mshanemc approved these changes

@xyc xyc Awaiting requested review from xyc xyc was automatically assigned from forcedotcom/ide-experience

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shetzel @WillieRuemmele @mshanemc