Sm/registry-children #458
Merged
Sm/registry-children #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
requested review from
RitamAgrawal,
iowillhoit,
shetzel and
WillieRuemmele
iowillhoit
approved these changes
Sep 27, 2021
WillieRuemmele
approved these changes
Sep 27, 2021
shetzel
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
childTypespropertiestypeswith achildrenproperty have a matching entry inchildTypesWhat issues does this PR fix or reference?
@W-9951980@
forcedotcom/cli#1199
@W-9951980@
forcedotcom/cli#1200
W-9952021
QA Notes:
Besides testing that this fixes the 2 types named in the github issue,
make sure that the other childTypes added in registryjson don't cause problems deploy/retrieve/converting their metdata. They were added because the registryValidation test flagged them as missing.