Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sh/exclude custom field translations #444

Merged
merged 4 commits into from
Sep 2, 2021

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Aug 31, 2021

What does this PR do?

Adds the ability to prevent metadata type entries from being written to the manifest. These are special cases where the type must be defined in the registry so it can be identified and possibly decomposed/recomposed, but they are not supported by the Metadata API.

Example type: CustomFieldTranslation

What issues does this PR fix or reference?

@W-9831738@

Functionality Before

The type entry was added to the manifest and the deploy or retrieve request would fail with an error like this:
Unknown type name 'CustomFieldTranslation' specified in package.xml

Functionality After

Successful deploy/retrieve because the type is not added to the manifest.

@shetzel shetzel requested review from a team as code owners August 31, 2021 22:21
Copy link
Member

@WillieRuemmele WillieRuemmele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, super generic and easy to add another type like this!

@WillieRuemmele
Copy link
Member

verified it would write manifests with only CustomObjectTranslation when converting/deploying/retrieving

and I removed the **/objectTranslations/** entry from the .forceignore

@WillieRuemmele WillieRuemmele merged commit 18e3674 into main Sep 2, 2021
@WillieRuemmele WillieRuemmele deleted the sh/exclude-CustomFieldTranslations branch September 2, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants