fix: support toolbelt suffixes #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
CustomPageWebLink:
- is able to deploy both suffixes (above)
- CANNOT deploy
.custompageweblinksuffix without a.weblinkfile ->"An object 'test' of type CustomPageWebLink was named in package.xml, but was not found in zipped directory" - retrieve will create a
.weblinkfile - retrieve won't override a
.custompageweblikto.weblink
Index:
- deploy works with test repo on this SDR branch, fails on develop
- source:convert works
- source:convert -> mdapi:convert will throw
Unexpected file found in package directory: /Users/william.ruemmele/projects/scratches/github1141-big-object-index/force-app/main/default/objects/Test__b/indexes/TestIndex.index-meta.xml - change that file it complains about above to use
.indexeand it works - retrieve works
- SDR will retrieve and write as
indexeandindex
…otcom/source-deploy-retrieve into sm/toolbelt-compatibility
|
Now able to deploy singular |
WillieRuemmele
approved these changes
Aug 18, 2021
AnanyaJha
pushed a commit
that referenced
this pull request
Aug 19, 2021
* fix: force fullName to CustomLabels * chore: update prop name * fix: backward support for toolbelt suffix differences * Revert "fix: backward support for toolbelt suffix differences" This reverts commit 9cf9505. * fix: support toolbelt suffixes * feat: support legacy suffix conversion Co-authored-by: Mike Donnalley <[email protected]> Co-authored-by: Willie Ruemmele <[email protected]>
shetzel
added a commit
that referenced
this pull request
Aug 20, 2021
* fix: export all public TS types and interfaces (#423) * fix: making exports in the right format @W-9727845@ * chore: removing yarn changes * fix: xml nodes might not be arrays (#424) Co-authored-by: Willie Ruemmele <[email protected]> * fix: throw an error for unexpected child types (#426) * fix: throw an error for unexpected child types * fix: throw better error when transforming invalid child * fix: ensure valid children during retrieve Co-authored-by: Willie Ruemmele <[email protected]> * fix: force fullName to CustomLabels (#427) * fix: force fullName to CustomLabels * chore: update prop name * fix: backward support for toolbelt suffix differences * Revert "fix: backward support for toolbelt suffix differences" This reverts commit 9cf9505. Co-authored-by: mshanemc <[email protected]> Co-authored-by: Willie Ruemmele <[email protected]> * fix: forceIgnore does not work for `SFDX: Retrieve Source in Manifest from Org` in vscode extension (#413) * fix: forceIgnore does not work with retrieve manifest * fix: matchingContent subfolder * Wr/content type of undefined (#429) * chore: initial pass on preventing improperly structured static resources * chore: added error message Co-authored-by: Shane McLaughlin <[email protected]> * fix: support toolbelt suffixes (#428) * fix: force fullName to CustomLabels * chore: update prop name * fix: backward support for toolbelt suffix differences * Revert "fix: backward support for toolbelt suffix differences" This reverts commit 9cf9505. * fix: support toolbelt suffixes * feat: support legacy suffix conversion Co-authored-by: Mike Donnalley <[email protected]> Co-authored-by: Willie Ruemmele <[email protected]> Co-authored-by: vamsimundra <[email protected]> Co-authored-by: Shane McLaughlin <[email protected]> Co-authored-by: Willie Ruemmele <[email protected]> Co-authored-by: Steve Hetzel <[email protected]> Co-authored-by: Mike Donnalley <[email protected]> Co-authored-by: Violet Yao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
toolbelt had two differences with SDR on metadata suffixes. This changes adds an additional suffix key pointing to the correct metadata type for index (big object indexes, child of customObject) and customwebpagelink.
For top-level type (customwebpagelink, not indexes) this also adds a new registry type property called
legacySuffix. If that exists, the destination xml location does areplaceto swap out the suffix (the existing code was justsliceing offmeta-xmlwhich would preserve incorrect suffixes even when SDR knew the proper type. That should provide deployable, corrected output forconvertanddeploycommands.This should have no effect on any other metadata types where there is no
legacySuffixprovided.What issues does this PR fix or reference?
forcedotcom/cli#1141 , @W-9771788@ @W-9762131@
AC: files should deploy with either or both suffix/types
files with the toolbelt type should retrieve/merge into the existing file
newly retrieved files should only use the new, correct SDR suffixes
please test source:convert with this