fix: getComponent won't throw when parent is ignored #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
commented
Aug 9, 2021
| @@ -54,7 +54,7 @@ export abstract class BaseSourceAdapter implements SourceAdapter { | |||
|
|
|||
| let component: SourceComponent; | |||
| if (rootMetadata) { | |||
| const componentName = this.type.inFolder | |||
| const componentName = this.type.folderType | |||
There was a problem hiding this comment.
inFolder was deprecated, folderType was the suggested replacement
shetzel
approved these changes
Aug 11, 2021
xyc
pushed a commit
that referenced
this pull request
Aug 12, 2021
xyc
pushed a commit
that referenced
this pull request
Aug 12, 2021
* feat: enable typedoc generation in circleci publish job (#392) * feat: enable doc generation in circleci publish * fix: getComponent won't throw when parent is ignored (#418) * feat: adds support for destructive changes (#420) * feat: adds support for destructive changes SourceComponents can now be marked for delete and added to ComponentSets. Conversion will then create a destructiveChangesPost.xml and include with the deploy. * feat: add ability to do destructiveChangesPre.xml Co-authored-by: Willie Ruemmele <[email protected]> Co-authored-by: Violet Yao <[email protected]> Co-authored-by: Willie Ruemmele <[email protected]> Co-authored-by: Steve Hetzel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
the
decomposedSourceAdapterwas callingbaseSourceAdapter.getComponentswhich was throwing an error when a parent xml file wasn't found or was .forceignore'dthis wasn't working for decomposed types because the parent isn't required... and so it was throwing when it shouldn't - blocking functionality.
I overrode the
getComponentsin thedecomposedSourceAdapteradapter so that it wouldn't throw an error in that scenarioWhat issues does this PR fix or reference?
forcedotcom/cli#1110, forcedotcom/cli#1106, @W-9720135@
Functionality Before
<insert gif and/or summary>
Functionality After
Source was successfully converted to Metadata API format<insert gif and/or summary>