fix: expand mdTransfer error #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
reviewed
Apr 3, 2024
| error.setData({ | ||
| id: this.id, | ||
| }); | ||
|
|
||
| if (error.stack && err.stack) { |
There was a problem hiding this comment.
how would error.stack ever be truthy if we just constructed it?
There was a problem hiding this comment.
all errors have a stack trace set when instantiated:
node -e 'const err= new Error(); console.log(err.stack);'
mshanemc
requested changes
Apr 3, 2024
| @@ -115,14 +115,26 @@ export abstract class MetadataTransfer< | |||
| } | |||
| return result; | |||
| } catch (e) { | |||
There was a problem hiding this comment.
this might be better as an exported function (pass in the e and the id) so that we could have a UT that imports it and throws various errors at it (regular Error, SfError, an isogit error) and asserts that we're giving back SfErrors with the correct input.
mshanemc
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
updates
MetadataTransfer.pollStatuserror handling to expand the mdTransfer error with error data/actions if the failure throws an SfError.An example of this is STL throwing on source-tracking after a CLI deploy (which happens on the postdeploy hook on SDR).
One customer is getting the
multiple git erroriso-git failure on STL but the path errors don't show up in the CLI final error.See this thread:
https://salesforce-internal.slack.com/archives/G02K6C90RBJ/p1711480148180689
What issues does this PR fix or reference?
@W-15347866@
Functionality Before
errors in post retrieve/deploy get swallowed in mdTransfer catch block.
Functionality After
mdTransfer will include cause error data (if instanceof SfError) and actions.
<insert gif and/or summary>