Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore missing error actions #1020

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

we weren't showing the actions correctly for an error

What issues does this PR fix or reference?

forcedotcom/cli#2237
@W-13628477@

@mshanemc mshanemc requested a review from a team as a code owner June 22, 2023 17:45
@WillieRuemmele
Copy link
Member

QA Notes


create 2 VF pages in the org, page1, page2, pull them down into the org
add **/pages/page1.page to the .forceignore

 ➜  sf project retrieve start --metadata 'ApexPage:*' 
Preparing retrieve request...
Error (1): ApexPage metadata types require source files, but /Users/william.ruemmele/projects/scratches/dreamhouse-lPreparing retrieve request... done

link this change through PDR
✅ : see more information

 ➜  sf project retrieve start --metadata 'ApexPage:*' 
Preparing retrieve request...
Error (1): ApexPage metadata types require source files, but /Users/william.ruemmele/projects/scratches/dreamhouse-lwc/force-app/main/default/pages/page1.page is forceignored.

Try this:

- Metadata types with content are composed of two files: a content file (ie MyApexClass.cls) and a -meta.xml file (i.e MyApexClass.cls-meta.xml). You must include both files in your .forceignore file. Or try appending “\*” to your existing .forceignore entry.

See <https://developer.salesforce.com/docs/atlas.en-us.sfdx_dev.meta/sfdx_dev/sfdx_dev_exclude_source.htm> for exampPreparing retrieve request... done

✅ : change the .forceignore entry to end with page1* and attempt the retrieve, only page2 is pulled down

@WillieRuemmele WillieRuemmele merged commit dbbeb21 into main Jun 26, 2023
@WillieRuemmele WillieRuemmele deleted the sm/error-output-for-ignored-files branch June 26, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants