refactor: core4 so use native jsforce deployRecent

forcedotcom · May 30, 2023 · 6c3e10b · 6c3e10b · svc-cli-bot · May 30, 2023
1 parent 0d1799c
commit 6c3e10b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/client/metadataApiDeploy.ts b/src/client/metadataApiDeploy.ts
@@ -273,7 +273,7 @@ export class MetadataApiDeploy extends MetadataTransfer<
     }
 
     const conn = await this.getConnection();
-    const response = (await conn.deployRecentValidation({
+    const response = (await conn.metadata.deployRecentValidation({
       id: this.id,
       rest,
     })) as unknown as AsyncResult | string;

diff --git a/test/mock/client/transferOperations.ts b/test/mock/client/transferOperations.ts
@@ -80,10 +80,10 @@ export async function stubMetadataDeploy(
 
   deployStub.withArgs(zipBuffer, options.apiOptions ?? defaultOptions).resolves(MOCK_ASYNC_RESULT);
 
-  const deployRecentlyValidatedIdStub = sandbox.stub(connection, 'deployRecentValidation');
+  const deployRecentlyValidatedIdStub = sandbox.stub(connection.metadata, 'deployRecentValidation');
   deployRecentlyValidatedIdStub
     .withArgs({ id: MOCK_ASYNC_RESULT.id, rest: true })
-    .resolves(MOCK_RECENTLY_VALIDATED_ID_REST)
+    .resolves(MOCK_RECENTLY_VALIDATED_ID_REST.id)
     .withArgs({ id: MOCK_ASYNC_RESULT.id, rest: false })
     // @ts-ignore overriding return type to match API
     .resolves(MOCK_RECENTLY_VALIDATED_ID_SOAP);
Benchmark suite	Current: `6c3e10b`	Previous: `15150cf`	Ratio
`eda-componentSetCreate-linux`	`234` ms	`275` ms	`0.85`
`eda-sourceToMdapi-linux`	`5674` ms	`7354` ms	`0.77`
`eda-sourceToZip-linux`	`4884` ms	`5508` ms	`0.89`
`eda-mdapiToSource-linux`	`4069` ms	`5341` ms	`0.76`
`lotsOfClasses-componentSetCreate-linux`	`482` ms	`563` ms	`0.86`
`lotsOfClasses-sourceToMdapi-linux`	`9166` ms	`10906` ms	`0.84`
`lotsOfClasses-sourceToZip-linux`	`7809` ms	`9989` ms	`0.78`
`lotsOfClasses-mdapiToSource-linux`	`4696` ms	`6372` ms	`0.74`
`lotsOfClassesOneDir-componentSetCreate-linux`	`803` ms	`993` ms	`0.81`
`lotsOfClassesOneDir-sourceToMdapi-linux`	`13246` ms	`15687` ms	`0.84`
`lotsOfClassesOneDir-sourceToZip-linux`	`13280` ms	`12492` ms	`1.06`
`lotsOfClassesOneDir-mdapiToSource-linux`	`8962` ms	`10761` ms	`0.83`
Benchmark suite	Current: `6c3e10b`	Previous: `15150cf`	Ratio
`eda-componentSetCreate-win32`	`674` ms	`416` ms	`1.62`
`eda-sourceToMdapi-win32`	`11472` ms	`9102` ms	`1.26`
`eda-sourceToZip-win32`	`8901` ms	`6355` ms	`1.40`
`eda-mdapiToSource-win32`	`12224` ms	`7907` ms	`1.55`
`lotsOfClasses-componentSetCreate-win32`	`1513` ms	`890` ms	`1.70`
`lotsOfClasses-sourceToMdapi-win32`	`16679` ms	`11500` ms	`1.45`
`lotsOfClasses-sourceToZip-win32`	`11314` ms	`7997` ms	`1.41`
`lotsOfClasses-mdapiToSource-win32`	`13902` ms	`9614` ms	`1.45`
`lotsOfClassesOneDir-componentSetCreate-win32`	`2654` ms	`1578` ms	`1.68`
`lotsOfClassesOneDir-sourceToMdapi-win32`	`28346` ms	`19517` ms	`1.45`
`lotsOfClassesOneDir-sourceToZip-win32`	`18476` ms	`13147` ms	`1.41`
`lotsOfClassesOneDir-mdapiToSource-win32`	`25242` ms	`17462` ms	`1.45`