Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Tnoonan/develop #57

Merged
merged 2 commits into from
Mar 20, 2019
Merged

Tnoonan/develop #57

merged 2 commits into from
Mar 20, 2019

Conversation

tnoonan-salesforce
Copy link
Contributor

No description provided.

@@ -0,0 +1 @@
module.exports = { extends: ['@commitlint/config-conventional'] };
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linter must have been upgraded and this file is required now.
conventional-changelog/commitlint#583

@@ -1,7 +1,7 @@
{
"extends": "@salesforce/dev-config/nyc",
"lines": 76,
"statements": 76,
"lines": 73,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why these watermark changes are required for a yarn.lock update.

Copy link
Contributor

@rbergman rbergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- are these mostly lint fixes?

@tnoonan-salesforce
Copy link
Contributor Author

Yeah

@tnoonan-salesforce tnoonan-salesforce merged commit d00da32 into develop Mar 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants