fix: ensure the hubOrg passes is actually a DevHub, throw error if not #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
force-pushed
the
wr/devHubIsNotDevHub
branch
from
a5ff88a to
7f003b2
Compare
Co-authored-by: Juliet Shackell <[email protected]>
cristiand391
approved these changes
Oct 12, 2022
| @@ -277,6 +277,9 @@ export const requestScratchOrgCreation = async ( | |||
| scratchOrgRequest: ScratchOrgInfo, | |||
| settings: SettingsGenerator | |||
| ): Promise<SaveResult> => { | |||
| if (!hubOrg.isDevHubOrg()) { | |||
There was a problem hiding this comment.
note: this method relies on the isDevHub prop to be set in the auth file, this prop is set based on a server check when creating and saving the auth file after this change was merged: #560 (comment)
if a user auth'd to a hub before that change ⬆️ was merged and starts to get the error then a re-auth should solve it.
There was a problem hiding this comment.
@WillieRuemmele @cristiand391, this is doing a good job of informing customers of the problem (see @W-11791190). That's great! Now when they enable the org as a devhub, we need to help them know to re-auth.
Can we add a note about that? Can we link to an FAQ? Can we provide a --update-devhub-status option to the some command?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
throws a nicer error message when the
hubOrgis not actually enabled as aDevHubBefore
ERROR running force:org:create: The requested resource does not existAfter
ERROR running force:org:create: Ensure that org, with id: [email protected] and username 00D530000008eONEAY is enabled as a DevHub*Messaging to be reviewed by Juliet
What issues does this PR fix or reference?
@W-11838125@