Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sm/fix-clone #623

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Sm/fix-clone #623

merged 2 commits into from
Jul 26, 2022

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

primary: swap out a field from a query result

other:

  • variable renaming and jsdoc for disambiguation
  • return promises that consumers can await

What issues does this PR fix or reference?

forcedotcom/cli#1637
@W-11468987@

@cristiand391
Copy link
Member

QA notes:

yarn linked this branch into plugin-org:

before:

force:org:clone would return:
ERROR running force:org:clone: Sandbox Info ID: id value of incorrect type: 0GR4p000000CpUUGA0
for any sbx, wrong ID

after:
✅ same arguments, successfully creates a sandbox clone request.

@cristiand391 cristiand391 merged commit 2372f03 into v3 Jul 26, 2022
@cristiand391 cristiand391 deleted the sm/fix-clone branch July 26, 2022 18:06
@cristiand391 cristiand391 mentioned this pull request Jul 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillieRuemmele WillieRuemmele WillieRuemmele approved these changes

@peternhale peternhale peternhale approved these changes

@cristiand391 cristiand391 cristiand391 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mshanemc @cristiand391 @peternhale @WillieRuemmele