Sm/fix is scratch #610
Sm/fix is scratch #610
Conversation
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): SF-CLI-BOT <s***@g***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated. |
| @@ -655,7 +655,7 @@ export class Org extends AsyncOptionalCreatable<Org.Options> { | |||
| const username = this.getUsername(); | |||
| if (username) { | |||
| const organization = await this.retrieveOrganizationInformation(); | |||
| const isScratch = organization.IsSandbox && organization.TrialExpirationDate; | |||
| const isScratch = organization.IsSandbox && Boolean(organization.TrialExpirationDate); | |||
There was a problem hiding this comment.
surprising that it's not !organization.IsSandbox. Seems like .IsSandbox should not be true when it's a scratch org... so continues the difficulties of determining scratch orgs
There was a problem hiding this comment.
It's also weird that the && in the middle doesn't turn the whole expression into a boolean, thanks JavaScript.
Also a place where TypeScript can help 😄
There was a problem hiding this comment.
to the server, isSandbox means, "is it running on sandbox infra?" and therefore scratch orgs are sandboxes.
https://developer.salesforce.com/docs/atlas.en-us.object_reference.meta/object_reference/sforce_api_objects_organization.htm
I know. Not confusing at all
There was a problem hiding this comment.
I guess IsSandbox ? it's a sandbox : it's a prod org no options for scratch orgs :)
There was a problem hiding this comment.
it's the enum-based keys, combined with types that extend & JsonMap, that prevented the stateAggregator.orgs.update from catching the type error.
😢
There was a problem hiding this comment.
Mike fixed some typing elsewhere to prevent this from happening. I merged those in.
fix: update AuthFields type
|
🥳 |
see forcedotcom/cli#1598
@W-11358405@