Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy settings in mdapi format #608

Merged
merged 14 commits into from
Jul 6, 2022
Merged

Deploy settings in mdapi format #608

merged 14 commits into from
Jul 6, 2022

Conversation

maggiben
Copy link
Contributor

@maggiben maggiben commented Jun 28, 2022

Deploy settings in mdapi format

Testing notes:

Link: core in plugin-org main branch is ok, then test the beta commands, besides the regular org, customer has provided a custom org that was failing before you can look it up in this issue: forcedotcom/cli#1526

This PR: was previously created for V1 if you're interested in seeing the comments there please check here

@W-11163191@

Copy link
Contributor

@mshanemc mshanemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice progress. Those tests for the package.xml turned out nice!

TODO:
address PR feedback
write some tests that assert the object files

src/org/scratchOrgSettingsGenerator.ts Outdated Show resolved Hide resolved
src/org/scratchOrgSettingsGenerator.ts Outdated Show resolved Hide resolved
src/org/scratchOrgSettingsGenerator.ts Outdated Show resolved Hide resolved
src/org/scratchOrgSettingsGenerator.ts Outdated Show resolved Hide resolved
src/org/scratchOrgSettingsGenerator.ts Outdated Show resolved Hide resolved
src/org/scratchOrgSettingsGenerator.ts Outdated Show resolved Hide resolved
src/org/scratchOrgSettingsGenerator.ts Outdated Show resolved Hide resolved
src/org/scratchOrgSettingsGenerator.ts Show resolved Hide resolved
src/org/scratchOrgSettingsGenerator.ts Outdated Show resolved Hide resolved
src/org/scratchOrgSettingsGenerator.ts Outdated Show resolved Hide resolved
src/org/scratchOrgSettingsGenerator.ts Outdated Show resolved Hide resolved
src/org/scratchOrgSettingsGenerator.ts Outdated Show resolved Hide resolved
@maggiben maggiben requested a review from mshanemc July 3, 2022 18:43
mshanemc
mshanemc previously approved these changes Jul 5, 2022
mshanemc
mshanemc previously approved these changes Jul 6, 2022
@mshanemc
Copy link
Contributor

mshanemc commented Jul 6, 2022

QA notes:

this branch linked into plugin-org w/ org:beta:create

✅ create an org with a features/settings-only scratch def
❌ use object settings from dev guide

ERROR running force:org:beta:create:  A scratch org was created with username [email protected], but the settings failed to deploy due to: 
Error parsing file: Element {http://soap.sforce.com/2006/04/metadata}businessProcesses invalid at this location in type RecordType

Screen Shot 2022-07-06 at 3 28 01 PM

⚠️ customer provided repo

../../plugin-org/bin/dev force:org:beta:create -f config/project-scratch-def.json -d 1 -s
(node:54258) Warning: Successfully created org with ID: 00D22000000DnwIEAS and name: [email protected]. Unfortunately, source tracking isn’t working as expected. If you run force:source:status, the results may be incorrect. Try again by creating another scratch org.
(Use `node --trace-warnings ...` to show where the warning was created)
Successfully created scratch org: 00D22000000DnwIEAS, username: [email protected].

retry of the above resulted in the same error. It's coming from jsforce Connection and I'm trying to find a fix for it.

mshanemc
mshanemc previously approved these changes Jul 6, 2022
Copy link
Contributor

@mshanemc mshanemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, these changes fixed the issue I found

@mshanemc
Copy link
Contributor

mshanemc commented Jul 6, 2022

QA, round 2

use object settings from dev guide
✅ deploys with no errors or warnings
✅ oppty is private in the org's SharingSettings

@mshanemc mshanemc merged commit 619ca57 into v3 Jul 6, 2022
@mshanemc mshanemc deleted the bm/W-11163191-v3 branch July 6, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants