Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(url): support sandboxes with enhanced domains enabled #597

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

cristiand391
Copy link
Member

@cristiand391 cristiand391 commented Jun 14, 2022

What does this PR do?

Adds support for sandboxes with enhanced domains enabled.

Considerations for enhanced domains

Differences Between Sandbox and Production
When you enable enhanced domains, your production My Domain login URL format, MyDomainName.my.salesforce.com, doesn’t change unless you also change your My Domain name or suffix. However, enabling enhanced domains in a sandbox adds the word “sandbox” to the org’s My Domain login URL: MyDomainName--SandboxName.sandbox.my.salesforce.com.

QA steps:

  1. checkout the plugin-orgparking-orbit PR locally fix: parking orbit plugin-org salesforcecli/plugin-org#332
  2. checkout fix(url): support sandboxes with enhanced domains enabled #597
  3. yarn build and link it into plugin-org
  4. try force:org:open -u <sanbdox-username> with a sbox with enhanced domains enabled, it should open it in the browser.

What issues does this PR fix or reference?

@W-11286708@
forcedotcom/cli#1556

@mshanemc
Copy link
Contributor

mshanemc commented Jun 15, 2022

QA notes:

I tested this on a sandbox that's been around for a long time. It didn't have an error without this change (looks like it properly handles redirects from the existing un-enhanced domain)
✅ this PR doesn't change anything

I tested this on a sandbox known to not work with the current code
✅ can replicate the problem
✅ this PR fixes it

I opened a scratch and prod org just for fun. all good

@mshanemc mshanemc merged commit d56a859 into v3 Jun 15, 2022
@mshanemc mshanemc deleted the cd/fix-enhanced-domains branch June 15, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants