Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return all info from AuthInfo.listAllAuthorizations #449

Merged
merged 4 commits into from
Aug 2, 2021

Conversation

mdonnalley
Copy link
Contributor

Return more information from AuthInfo.listAllAuthorizations

@W-9670252@
@ W-9680192@

Copy link
Contributor

@peternhale peternhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdonnalley I was expecting a change to SfOrg

export type SfOrg = {
  alias: Optional<string>;
  username: Optional<string>;
  orgId: Optional<string>;
  instanceUrl: Optional<string>;
  accessToken?: string;
  oauthMethod?: 'jwt' | 'web' | 'token' | 'unknown';
  error?: string;
} & SfEntry;

to

  aliases: Optional<string[]>;
  username: Optional<string>;
  orgId: Optional<string>;
  instanceUrl: Optional<string>;
  accessToken?: string;
  oauthMethod?: 'jwt' | 'web' | 'token' | 'unknown';
  error?: string;
} & SfEntry;

@mdonnalley mdonnalley requested a review from peternhale July 30, 2021 18:18
src/org/authInfo.ts Outdated Show resolved Hide resolved
src/org/authInfo.ts Outdated Show resolved Hide resolved
src/org/authInfo.ts Show resolved Hide resolved
@mdonnalley mdonnalley requested a review from RodEsp August 2, 2021 16:33
@mdonnalley mdonnalley merged commit 17e60ea into v3 Aug 2, 2021
@mdonnalley mdonnalley deleted the mdonnalley/update-listAllAuthorizations branch August 2, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants