Core URL class SfdcUrl

[maggiben]

WIP

What does this PR do?

A new SfdcUrl class derived from WHATWG URL API with some extensions that consolidate a lot of url utilities into a single class.

What functionality is included in this class ?

• getJwtAudienceUrl
• isSandboxUrl
• isSalesforceDomain
• isInternalUrl
• isLocalUrl
• checkLightningDomain
• lookup

Backward compatibility:

• getJwtAudienceUrl
• sfdc.isInternalUrl

Want to include a new feature ? please refer to the original spike doc here

What issues does this PR fix or reference?

@W-9457855@

[peternhale]

@maggiben @mshanemc I was expecting to see changes in core that would reflect the availability of this URL class wherever node URL is being used. Will that be forthcoming?

[mshanemc]

QA notes

Repro
from this branch locally yarn link
from main branch on plugin-auth, yarn link "@salesforce/core"

set all the required envs

• TESTKIT_HUB_USERNAME
• TESTKIT_JWT_CLIENT_ID
• TESTKIT_JWT_KEY (one long no-line-break string of the contents of the key)
• TESTKIT_HUB_INSTANCE
• TESTKIT_AUTH_URL

yarn build && yarn test:nuts

You can verify that the NUTs are passing on regular core by doing yarn link "@salesforce/core" and then the suggested install command.

  auth:logout NUTs
    1) "before each" hook for "should remove the org specified by the -u flag (json)"


  auth:accesstoken:store NUTs
    2) "before all" hook: prepare session and ensure environment variables for "should authorize an org using access token (json)"


  auth:jwt:grant NUTs
    3) should authorize an org using jwt (json)
    4) "after each" hook for "should authorize an org using jwt (json)"


  auth:list NUTs
    ✓ should list auth files (json)
    ✓ should list auth files (human readable)


  auth:sfdxurl:store NUTs
    ✓ should authorize an org using sfdxurl (json) (4797ms)
    ✓ should authorize an org using sfdxurl (human readable) (4093ms)


  verify discovery/id of scratch org
    ✓ should have the scratch org in auth files
    ✓ should logout from the org)
    ✓ should NOT have the scratch org in auth files
    5) should login to the org via jwt grant
    6) should have the devhubUsername in the auth file
    7) "after all" hook for "should have the devhubUsername in the auth file"


  7 passing (48s)
  7 failing

[mshanemc]

QA Notes: plugin-org (open, myDomainResolver stuff) NUTs worked fine.

[maggiben]

I was able to successfully run the NUTs on plugin-auth:

changed been made

[mshanemc]

QA notes:

good: plugin config is catching bad URLs.
bad: toolbelt still has an import of jwtAudienceUrl until this merges: https://github.com/salesforcecli/toolbelt/pull/74

because of https://github.com/salesforcecli/toolbelt/blob/4d5cf46b231702741905d431edd99060267011ef/src/lib/core/force.ts#L36

I didn't catch this in review, only noticed it while getting read to QA stuff. That would be a breaking change. Let's avoid that...it'll be a nice puzzle.

checkLightningDomain has the same problem, but I don't think anyone is using that one that I could find.

[mshanemc]

nice tests!