chore: write only when needed

forcedotcom · Jun 28, 2023 · b3960eb · b3960eb
1 parent af8eb5d
commit b3960eb
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/src/config/configAggregator.ts b/src/config/configAggregator.ts
@@ -335,10 +335,16 @@ export class ConfigAggregator extends AsyncOptionalCreatable<ConfigAggregator.Op
   }
 
   public async unsetByValue(key: string): Promise<void> {
-    this.localConfig?.getKeysByValue(key).map((k) => this.localConfig?.unset(k));
-    this.globalConfig?.getKeysByValue(key).map((k) => this.globalConfig?.unset(k));
-    await this.localConfig?.write();
-    await this.globalConfig?.write();
+    const hasLocalWrites = this.localConfig
+      ?.getKeysByValue(key)
+      .map((k) => this.localConfig?.unset(k))
+      .some(Boolean);
+    if (hasLocalWrites) await this.localConfig?.write();
+    const hasGlobalWrites = this.globalConfig
+      ?.getKeysByValue(key)
+      .map((k) => this.globalConfig?.unset(k))
+      .some(Boolean);
+    if (hasGlobalWrites) await this.globalConfig?.write();
   }
 
   /**

diff --git a/test/unit/org/orgTest.ts b/test/unit/org/orgTest.ts
@@ -331,13 +331,13 @@ describe('Org Tests', () => {
 
         it('should unset the alias and any configs', async () => {
           const dev = await createOrgViaAuthInfo(testData.username);
-
+          const stateAggregator = await StateAggregator.getInstance();
+          await ConfigAggregator.create();
           const orgTestData = new MockTestOrgData();
           const org = await createOrgViaAuthInfo(orgTestData.username, orgTestData);
           const username = ensureString(org.getUsername());
           $$.setConfigStubContents('Config', { contents: { [OrgConfigProperties.TARGET_ORG]: username } });
           expect($$.getConfigStubContents('Config')).to.deep.equal({ 'target-org': username });
-          const stateAggregator = await StateAggregator.getInstance();
 
           await stateAggregator.aliases.setAndSave('deleteThisAlias', username);
           expect(stateAggregator.aliases.getUsername('deleteThisAlias')).to.equal(username);