Skip to content

Commit

Permalink
test: use warn level to capture real (non-noop) traffic
Browse files Browse the repository at this point in the history
  • Loading branch information
mshanemc committed Jun 28, 2023
1 parent d62da01 commit af4e071
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions test/perf/logger/main.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,19 @@ suite
Logger.childFromRoot('benchmarkChild');
})
.add('Logging a string on root logger', () => {
logger.debug('this is a string');
logger.warn('this is a string');
})
.add('Logging an object on root logger', () => {
logger.debug({ foo: 1, bar: 2, baz: 3 });
logger.warn({ foo: 1, bar: 2, baz: 3 });
})
.add('Logging an object with a message on root logger', () => {
logger.debug({ foo: 1, bar: 2, baz: 3 }, 'this is a message');
logger.warn({ foo: 1, bar: 2, baz: 3 }, 'this is a message');
})
.add('Logging an object with a redacted prop on root logger', () => {
logger.debug({ foo: 1, bar: 2, accessToken: '00D' });
logger.warn({ foo: 1, bar: 2, accessToken: '00D' });
})
.add('Logging a nested 3-level object on root logger', () => {
logger.debug({ foo: 1, bar: 2, baz: { foo: 1, bar: 2, baz: { foo: 1, bar: 2, baz: 3 } } });
logger.warn({ foo: 1, bar: 2, baz: { foo: 1, bar: 2, baz: { foo: 1, bar: 2, baz: 3 } } });
})
// add listeners
.on('cycle', (event: any) => {
Expand Down

4 comments on commit af4e071

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: af4e071 Previous: 5f0f741 Ratio
Child logger creation 8412 ops/sec (±1.40%) 382591 ops/sec (±2.63%) 45.48
Logging a string on root logger 57722 ops/sec (±1.27%) 94574492 ops/sec (±2.00%) 1638.45
Logging an object on root logger 46432 ops/sec (±1.21%) 66701506 ops/sec (±1.57%) 1436.54
Logging an object with a message on root logger 20828 ops/sec (±1.27%) 41363757 ops/sec (±1.81%) 1985.97
Logging an object with a redacted prop on root logger 42620 ops/sec (±1.13%) 70217750 ops/sec (±1.65%) 1647.53
Logging a nested 3-level object on root logger 38907 ops/sec (±1.24%) 35888226 ops/sec (±2.08%) 922.41

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - ubuntu-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: af4e071 Previous: 5f0f741 Ratio
Child logger creation 8412 ops/sec (±1.40%) 382591 ops/sec (±2.63%) 45.48
Logging a string on root logger 57722 ops/sec (±1.27%) 94574492 ops/sec (±2.00%) 1638.45
Logging an object on root logger 46432 ops/sec (±1.21%) 66701506 ops/sec (±1.57%) 1436.54
Logging an object with a message on root logger 20828 ops/sec (±1.27%) 41363757 ops/sec (±1.81%) 1985.97
Logging an object with a redacted prop on root logger 42620 ops/sec (±1.13%) 70217750 ops/sec (±1.65%) 1647.53
Logging a nested 3-level object on root logger 38907 ops/sec (±1.24%) 35888226 ops/sec (±2.08%) 922.41

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: af4e071 Previous: 5f0f741 Ratio
Child logger creation 3343 ops/sec (±2.16%) 281042 ops/sec (±5.22%) 84.07
Logging a string on root logger 53392 ops/sec (±1.32%) 84715611 ops/sec (±0.85%) 1586.67
Logging an object on root logger 41050 ops/sec (±1.87%) 72946725 ops/sec (±1.26%) 1777.02
Logging an object with a message on root logger 18245 ops/sec (±1.52%) 63003908 ops/sec (±3.01%) 3453.22
Logging an object with a redacted prop on root logger 33097 ops/sec (±3.16%) 57948991 ops/sec (±7.79%) 1750.88
Logging a nested 3-level object on root logger 30330 ops/sec (±2.93%) 39251837 ops/sec (±2.37%) 1294.16

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - windows-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: af4e071 Previous: 5f0f741 Ratio
Child logger creation 3343 ops/sec (±2.16%) 281042 ops/sec (±5.22%) 84.07
Logging a string on root logger 53392 ops/sec (±1.32%) 84715611 ops/sec (±0.85%) 1586.67
Logging an object on root logger 41050 ops/sec (±1.87%) 72946725 ops/sec (±1.26%) 1777.02
Logging an object with a message on root logger 18245 ops/sec (±1.52%) 63003908 ops/sec (±3.01%) 3453.22
Logging an object with a redacted prop on root logger 33097 ops/sec (±3.16%) 57948991 ops/sec (±7.79%) 1750.88
Logging a nested 3-level object on root logger 30330 ops/sec (±2.93%) 39251837 ops/sec (±2.37%) 1294.16

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.