test: verify auth nuts

forcedotcom · Jul 3, 2023 · 3f3b529 · 3f3b529 · svc-cli-bot · Jul 3, 2023
1 parent aab1552
commit 3f3b529
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 16 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -5,17 +5,17 @@ on:
   workflow_dispatch:
 
 jobs:
-  yarn-lockfile-check:
-    uses: salesforcecli/github-workflows/.github/workflows/lockFileCheck.yml@main
-  # Since the Windows unit tests take much longer, we run the linux unit tests first and then run the windows unit tests in parallel with NUTs
-  linux-unit-tests:
-    needs: yarn-lockfile-check
-    uses: salesforcecli/github-workflows/.github/workflows/unitTestsLinux.yml@main
-  windows-unit-tests:
-    needs: linux-unit-tests
-    uses: salesforcecli/github-workflows/.github/workflows/unitTestsWindows.yml@main
+  # yarn-lockfile-check:
+  #   uses: salesforcecli/github-workflows/.github/workflows/lockFileCheck.yml@main
+  # # Since the Windows unit tests take much longer, we run the linux unit tests first and then run the windows unit tests in parallel with NUTs
+  # linux-unit-tests:
+  #   needs: yarn-lockfile-check
+  #   uses: salesforcecli/github-workflows/.github/workflows/unitTestsLinux.yml@main
+  # windows-unit-tests:
+  #   needs: linux-unit-tests
+  #   uses: salesforcecli/github-workflows/.github/workflows/unitTestsWindows.yml@main
   nuts:
-    needs: linux-unit-tests
+    # needs: linux-unit-tests
     uses: salesforcecli/github-workflows/.github/workflows/externalNut.yml@main
     strategy:
       fail-fast: false

diff --git a/src/logger/logger.ts b/src/logger/logger.ts
@@ -285,7 +285,7 @@ export class Logger {
           transport: {
             pipeline: [
               {
-                target: '../../lib/logger/transformStream',
+                target: path.join('..', '..', 'lib', 'logger', 'transformStream'),
               },
               getWriteStream(level),
             ],
@@ -656,11 +656,6 @@ const getWriteStream = (level = 'warn'): pino.TransportSingleOptions => {
   ]);
   const logRotationPeriod = new Env().getString('SF_LOG_ROTATION_PERIOD') ?? '1d';
 
-  // eslint-disable-next-line no-console
-  console.log(
-    `destination is ${path.join(Global.SF_DIR, `sf-${rotator.get(logRotationPeriod) ?? rotator.get('1d')}.log`)}`
-  );
-
   return {
     // write to a rotating file
     target: 'pino/file',
Benchmark suite	Current: `3f3b529`	Previous: `aab1552`	Ratio
`Child logger creation`	`379811` ops/sec (`±3.45%`)	`400433` ops/sec (`±0.53%`)	`1.05`
`Logging a string on root logger`	`653571` ops/sec (`±12.84%`)	`639050` ops/sec (`±10.33%`)	`0.98`
`Logging an object on root logger`	`536895` ops/sec (`±9.77%`)	`551755` ops/sec (`±8.58%`)	`1.03`
`Logging an object with a message on root logger`	`14620` ops/sec (`±186.37%`)	`15218` ops/sec (`±186.20%`)	`1.04`
`Logging an object with a redacted prop on root logger`	`440965` ops/sec (`±10.32%`)	`427935` ops/sec (`±16.60%`)	`0.97`
`Logging a nested 3-level object on root logger`	`290573` ops/sec (`±10.60%`)	`312461` ops/sec (`±11.95%`)	`1.08`
Benchmark suite	Current: `3f3b529`	Previous: `aab1552`	Ratio
`Child logger creation`	`238556` ops/sec (`±0.97%`)	`318681` ops/sec (`±0.46%`)	`1.34`
`Logging a string on root logger`	`462543` ops/sec (`±13.82%`)	`606449` ops/sec (`±14.96%`)	`1.31`
`Logging an object on root logger`	`308548` ops/sec (`±21.01%`)	`320808` ops/sec (`±19.80%`)	`1.04`
`Logging an object with a message on root logger`	`168364` ops/sec (`±20.11%`)	`131826` ops/sec (`±20.97%`)	`0.78`
`Logging an object with a redacted prop on root logger`	`196176` ops/sec (`±19.12%`)	`220252` ops/sec (`±23.50%`)	`1.12`
`Logging a nested 3-level object on root logger`	`101608` ops/sec (`±25.06%`)	`145303` ops/sec (`±16.78%`)	`1.43`