chore: pr comments

forcedotcom · Jul 26, 2023 · 039cc19 · 039cc19 · svc-cli-bot · Jul 26, 2023
1 parent 6959776
commit 039cc19
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -15,7 +15,7 @@ jobs:
     needs: linux-unit-tests
     uses: salesforcecli/github-workflows/.github/workflows/unitTestsWindows.yml@main
   nuts:
-    # needs: linux-unit-tests
+    needs: linux-unit-tests
     uses: salesforcecli/github-workflows/.github/workflows/externalNut.yml@main
     strategy:
       fail-fast: false

diff --git a/src/logger/cleanup.ts b/src/logger/cleanup.ts
@@ -12,7 +12,7 @@ import { Logger } from './logger';
 /**
  * the odds of running are 1 in CLEAN_ODDS
  * ex: CLEAN_ODDS=100 implies 1 in 100
- * ex: CLEAN_ODDS=100 implies 1 in 1 (run every time)
+ * ex: CLEAN_ODDS=1 implies 1 in 1 (run every time)
  * */
 const CLEAN_ODDS = 100;
 const MAX_FILE_AGE_DAYS = 7;
Benchmark suite	Current: `039cc19`	Previous: `c6f4ddd`	Ratio
`Child logger creation`	`434357` ops/sec (`±1.63%`)	`15092` ops/sec (`±1.17%`)	`0.034745612480056726`
`Logging a string on root logger`	`459455` ops/sec (`±13.48%`)	`71082` ops/sec (`±1.07%`)	`0.15`
`Logging an object on root logger`	`386669` ops/sec (`±11.53%`)	`61022` ops/sec (`±0.19%`)	`0.16`
`Logging an object with a message on root logger`	`218843` ops/sec (`±16.21%`)	`29149` ops/sec (`±0.07%`)	`0.13`
`Logging an object with a redacted prop on root logger`	`317812` ops/sec (`±15.56%`)	`55075` ops/sec (`±0.09%`)	`0.17`
`Logging a nested 3-level object on root logger`	`1673` ops/sec (`±234.38%`)	`50079` ops/sec (`±0.15%`)	`29.93`
Benchmark suite	Current: `039cc19`	Previous: `c6f4ddd`	Ratio
`Child logger creation`	`471895` ops/sec (`±3.40%`)	`5735` ops/sec (`±7.79%`)	`0.012153127284671378`
`Logging a string on root logger`	`613151` ops/sec (`±6.81%`)	`58744` ops/sec (`±0.19%`)	`0.0958067425479205`
`Logging an object on root logger`	`484119` ops/sec (`±11.44%`)	`49662` ops/sec (`±0.52%`)	`0.10`
`Logging an object with a message on root logger`	`280276` ops/sec (`±17.21%`)	`23653` ops/sec (`±0.59%`)	`0.0843918137835562`
`Logging an object with a redacted prop on root logger`	`10975` ops/sec (`±197.32%`)	`45438` ops/sec (`±0.21%`)	`4.14`
`Logging a nested 3-level object on root logger`	`270933` ops/sec (`±13.81%`)	`40596` ops/sec (`±0.29%`)	`0.15`