Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scratch-def): add 'release' to schema properties for autocomplete #46

Closed
wants to merge 3 commits into from
Closed

feat(scratch-def): add 'release' to schema properties for autocomplete #46

wants to merge 3 commits into from

Conversation

douglascayers
Copy link
Contributor

@douglascayers douglascayers commented Apr 22, 2022

What does this PR do?

Adds release property to properties section of project-scratch-def.schema.json so that Visual Studio Code will autocomplete and validate that property.

What issues does this PR fix or reference?

Although release exists in the definitions section of project-scratch-def.schema.json, Visual Studio Code doesn't autocomplete or provide content-assist for that property in scratch org definition files because it's not listed in the properties section, too.

Functionality Before

No autocomplete
image

No validation
image

Functionality After

Autocomplete
image

Validation
image

How to Test

On my local machine I replaced ~/.vscode/extensions/salesforce.salesforcedx-vscode-core-54.9.0/node_modules/@salesforce/schemas/project-scratch-def.schema.json with the version in this pull request then restarted Visual Studio Code.

@douglascayers douglascayers requested a review from a team as a code owner April 22, 2022 00:40
@uip-robot-zz
Copy link

Git2Gus App is installed but the .git2gus/config.json doesn't exist.

@douglascayers
Copy link
Contributor Author

Git2Gus App is installed but the .git2gus/config.json doesn't exist.

That's been proposed in #39

Copy link
Contributor

@gbockus-sf gbockus-sf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verified change locally 👍 As long as the tests pass we're good to go.

@klewis-sfdc
Copy link
Contributor

Merged as PR #52 after auto builds ran on that PR. Thank you for the contribution @douglascayers!

@douglascayers douglascayers deleted the feature/release-scratchdef-property branch May 31, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants