feat(sfdx-project): add name property to project schema #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amphro
requested changes
Apr 2, 2021
sfdx-project.schema.json
Outdated
| "name": { | ||
| "title": "name", | ||
| "type": "string", | ||
| "description": "The name of your SFDX project." |
There was a problem hiding this comment.
Change this to "Salesforce project."
cafreeman
force-pushed
the
cfreeman/add-name-to-project-schema
branch
from
092a33c to
e94c6e9
Compare
|
@cafreeman I think this is ok, are you also going to update the documentation around this file ? e.g. https://developer.salesforce.com/docs/atlas.en-us.sfdx_dev.meta/sfdx_dev/sfdx_dev_ws_config.htm, https://developer.salesforce.com/docs/atlas.en-us.sfdx_dev.meta/sfdx_dev/sfdx_dev2gp_config_file.htm We should also open a PR to add this new attribute to the current scaffold commands in the Salesforce CLI (https://github.com/forcedotcom/salesforcedx-templates). |
|
@lcampos 👋 I've actually already opened up a PR over on the templates repo if you'd like to take a look forcedotcom/salesforcedx-templates#296 |
xyc
approved these changes
Apr 5, 2021
lcampos
approved these changes
Apr 5, 2021
amphro
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a name property to the
sfdx-project.jsonschemaWhat issues does this PR fix or reference?
https://gus.lightning.force.com/one/one.app#/alohaRedirect/a07AH0000009lOcYAI
Functionality Before
Functionality After
Should be no different except that the name field is documented.