Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scratch-def): add 'release' to schema properties for autocomplete #52

Merged
merged 3 commits into from
May 31, 2022

Conversation

klewis-sfdc
Copy link
Contributor

What does this PR do?

-- Adds release property to properties section of project-scratch-def.schema.json so that Visual Studio Code will autocomplete and validate that property. --

A community contribution from @douglascayers. See PR #46 for more detail.

What issues does this PR fix or reference?

#, @@

Functionality Before

<insert gif and/or summary>

Functionality After

<insert gif and/or summary>

@klewis-sfdc klewis-sfdc requested a review from a team as a code owner May 31, 2022 18:55
@klewis-sfdc klewis-sfdc requested a review from gbockus-sf May 31, 2022 18:55
@douglascayers
Copy link
Contributor

Thanks @klewis-sfdc -- curious though, why can't #46 be merged on its own? Why is #52 necessary?

@randi274 randi274 changed the title Pr/46 feat(scratch-def): add 'release' to schema properties for autocomplete May 31, 2022
@randi274
Copy link
Contributor

@douglascayers for security reasons our builds don't run on community contributed PRs, so only PRs from authorized contributors create automated builds for tests. Unfortunately we don't distinguish between inside-Salesforce-contributors and outside-Salesforce-contributors, so it does mean an extra step for us.

@douglascayers
Copy link
Contributor

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants