Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpdateTypeInfo for all file that has errors for any edit #905

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

praksb
Copy link
Contributor

@praksb praksb commented Jan 28, 2019

What does this PR do?

Update Apex LSP jar to fix issue where references might go stale when edits are applied in a certain order.

What issues does this PR fix or reference?

This fixes the problem in Apex LSP which may surface more often with refactorings enabled where when edits are applied in a certain order may result in stale references. We now update the typeinfos for all the error files on edits to avoid stale references in error files.

@W-5573514@

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #905 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #905   +/-   ##
========================================
  Coverage    60.88%   60.88%           
========================================
  Files           75       75           
  Lines         3382     3382           
  Branches       599      599           
========================================
  Hits          2059     2059           
  Misses        1216     1216           
  Partials       107      107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6c7c2d...3dbfbee. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #905 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #905   +/-   ##
========================================
  Coverage    60.88%   60.88%           
========================================
  Files           75       75           
  Lines         3382     3382           
  Branches       599      599           
========================================
  Hits          2059     2059           
  Misses        1216     1216           
  Partials       107      107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6c7c2d...3dbfbee. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 28, 2019

Codecov Report

Merging #905 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #905   +/-   ##
========================================
  Coverage    60.88%   60.88%           
========================================
  Files           75       75           
  Lines         3382     3382           
  Branches       599      599           
========================================
  Hits          2059     2059           
  Misses        1216     1216           
  Partials       107      107

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6c7c2d...3dbfbee. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants