Easy Deploy on Save #822

allileong · 2018-12-14T20:59:27Z

What does this PR do?

When the workspace setting for deploy-on-save is enabled, changes made to files inside of a package directory will trigger an automatic push or deploy, depending on the type of org that is connected to the workspace.

Note: This functionality is not working in Windows due to a problem with the GlobPattern and I have followed the following issue with VS Code: microsoft/vscode#65240

What issues does this PR fix or reference?

W-5552627, #577, #662

codecov · 2018-12-15T00:39:06Z

Codecov Report

Merging #822 into develop will decrease coverage by 0.07%.
The diff coverage is 73.52%.

@@             Coverage Diff             @@
##           develop     #822      +/-   ##
===========================================
- Coverage    73.26%   73.18%   -0.08%     
===========================================
  Files          168      174       +6     
  Lines         6815     6997     +182     
  Branches      1076     1094      +18     
===========================================
+ Hits          4993     5121     +128     
- Misses        1550     1599      +49     
- Partials       272      277       +5

Impacted Files	Coverage Δ
...rcedx-vscode-core/src/settings/sfdxCoreSettings.ts	`57.14% <0%> (-4.4%)`	⬇️
...ackages/salesforcedx-vscode-core/src/util/index.ts	`100% <100%> (ø)`
...ges/salesforcedx-vscode-core/src/settings/index.ts	`100% <100%> (ø)`	⬆️
...ages/salesforcedx-vscode-core/src/context/index.ts	`100% <100%> (ø)`	⬆️
.../salesforcedx-vscode-core/src/commands/commands.ts	`72.1% <20%> (-1.84%)`	⬇️
...forcedx-vscode-core/src/diagnostics/diagnostics.ts	`77.41% <50%> (-1.9%)`	⬇️
...edx-vscode-core/src/settings/pushOrDeployOnSave.ts	`60.82% <60.82%> (ø)`
...e-core/src/commands/forceSourceDeploySourcePath.ts	`61.11% <61.11%> (ø)`
...cedx-vscode-core/src/commands/forceSourceDeploy.ts	`27.58% <66.66%> (-14.92%)`	⬇️
...e-core/src/commands/forceSourceRetrieveManifest.ts	`75% <75%> (ø)`
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a526a...26af321. Read the comment docs.

allileong · 2018-12-18T00:26:58Z

.vscode/launch.json

@@ -38,7 +38,8 @@
      "args": ["--extensionDevelopmentPath=${workspaceRoot}/packages"],
      "stopOnEntry": false,
      "sourceMaps": true,
-      "outFiles": ["${workspaceRoot}/packages/*/out/src/**/*.js"]


Please disregard changes made to this file. I will be reverting all changes.

allileong · 2018-12-19T23:17:31Z

packages/salesforcedx-vscode-core/src/settings/pushOrDeployOnSave.ts

+const WAIT_TIME_IN_MS = 50;
+
+export async function registerPushOrDeployOnSave() {
+  if (sfdxCoreSettings.getPushOrDeployOnSaveEnabled()) {


We only register the file watcher if the push-or-deploy-on-save setting is already set to true on core activation. This means that if a user wants to turn on the feature, they will have to restart VS Code.

Disablement of the feature will be respected immediately due to the checks made in lines 43, 56, and 65, and will not require a restart of the extension.

lcampos · 2018-12-19T23:56:49Z

packages/system-tests/assets/sfdx-simple/.vscode/settings.json

@@ -1,3 +0,0 @@
-{


Why do we need to delete this ?

Thanks for catching this. I did not mean to delete this and will put it back.

lcampos · 2018-12-19T23:58:08Z

packages/salesforcedx-vscode-core/src/commands/forceSourceDeploy.ts


 vscode.workspace.onDidChangeTextDocument(e => {
  if (ForceSourceDeployExecutor.errorCollection.has(e.document.uri)) {
    ForceSourceDeployExecutor.errorCollection.delete(e.document.uri);
  }
 });

-export class ForceSourceDeployExecutor extends SfdxCommandletExecutor<
-  SelectedPath
+export abstract class ForceSourceDeployExecutor extends SfdxCommandletExecutor<


Awesome, this makes every type of deploy command render any deploy errors in the problem view.

lcampos · 2018-12-19T23:59:03Z

packages/salesforcedx-vscode-core/src/commands/forceSourceDeployManifest.ts

+    const commandBuilder = new SfdxCommandBuilder()
+      .withDescription(nls.localize('force_source_deploy_text'))
+      .withArg('force:source:deploy')
+      .withLogName('force_source_deploy')


Lets change this to fource_source_deploy_with_manifest

lcampos · 2018-12-20T00:01:13Z

packages/salesforcedx-vscode-core/src/commands/forceSourceDeploySourcePath.ts

+    const commandBuilder = new SfdxCommandBuilder()
+      .withDescription(nls.localize('force_source_deploy_text'))
+      .withArg('force:source:deploy')
+      .withLogName('force_source_deploy')


Lets change this to force_source_deploy_with_sourcepath to keep consistency with the log ids for the retrieve commands.

lcampos · 2018-12-20T00:05:22Z

packages/salesforcedx-vscode-core/src/commands/forceSourceRetrieveSourcePath.ts

+        if (sourcePathIsInPackageDirectory) {
+          return inputs;
+        }
+      } catch (error) {}


We should log this error and/or send it to our telemetry service.

lcampos · 2018-12-20T00:14:22Z

packages/salesforcedx-vscode-core/src/commands/forceSourceRetrieveSourcePath.ts

+
+        let sourcePathIsInPackageDirectory = false;
+        for (const packagePath of fullPackagePaths) {
+          if (sourcePath.startsWith(packagePath)) {


Wouldn't packagePath be something like force-app and sourcePath be something like Users/myuser/repo_name/force-app ?

Disregard this, I've checked and I was wrong 👍

lcampos

🚢

salesforce-cla · 2020-07-12T21:37:36Z

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Alli <a***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

allileong changed the title ~~[Almost-Ready-For-Review] Easy Deploy on Save~~ Easy Deploy on Save Dec 18, 2018

allileong requested review from lcampos and JimSuplizio December 18, 2018 00:17

allileong commented Dec 18, 2018

View reviewed changes

allileong mentioned this pull request Dec 18, 2018

Using '**' in a GlobPattern does not match any number of path segments in Windows microsoft/vscode#65240

Closed

lcampos mentioned this pull request Dec 19, 2018

Authorize orgs against different URLs (production, sandbox, or custom) #818

Merged

Alli added 22 commits December 19, 2018 13:35

Implement Push or Deploy on Save

dee202e

Undo changes to vscode settings

8ab37f0

Break up forceSourceDeploy

7f586d6

Split forceSourceDeploy into 3 separate commands

9454811

Break up forceSourceRetrieve

c0d8c74

Break up forceSourceRetrieve

bef8b17

Update unit tests for deploy/retrieve

a31cdab

Pull getPackageDirectoryPaths into a utility class

8658a6d

Add and update unit tests

9882539

Rename tests

b6a6b12

Fix unit tests

414c8f4

Add validation for source paths on deploy/retrieve

220abd0

Add unit tests for SourcePathChecker

0c6cf46

Updating unit tests

7e878ab

Clean up typos

29638a4

Clarify comment

33b583b

Rename command for consistency

b157ce3

Rename message string for accuracy

e50651b

Make error message simpler

e414fe1

Clean up code changes

d38d0e5

Use relative pattern instead of glob string

872c1d2

Deploy or Push file changes only

c8b8c70

allileong force-pushed the alli/easyDeployRebased branch from c727e41 to c8b8c70 Compare December 19, 2018 21:38

Alli added 2 commits December 19, 2018 15:04

Handle deleted file case

3e62fb9

Only register file watcher if setting is enabled

2f3d7b4

allileong commented Dec 19, 2018

View reviewed changes

lcampos reviewed Dec 19, 2018

View reviewed changes

lcampos reviewed Dec 20, 2018

View reviewed changes

Alli added 3 commits December 19, 2018 18:07

Move sfdxProjectJsonParser to core package

8ea0f11

Bump @salesforce/core to 1.1.1

1298767

Add back .vscode settings

26af321

lcampos approved these changes Dec 20, 2018

View reviewed changes

allileong merged commit a7385ab into develop Dec 20, 2018

allileong deleted the alli/easyDeployRebased branch December 20, 2018 17:11

anandbn mentioned this pull request Jan 20, 2019

Save All changed files #886

Closed

salesforce-cla bot added the cla:missing label Jul 12, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Easy Deploy on Save #822

Easy Deploy on Save #822

allileong commented Dec 14, 2018 •

edited by lcampos

Loading

codecov bot commented Dec 15, 2018 •

edited

Loading

allileong Dec 18, 2018

allileong Dec 19, 2018 •

edited

Loading

lcampos Dec 19, 2018

allileong Dec 20, 2018

lcampos Dec 19, 2018

lcampos Dec 19, 2018 •

edited

Loading

lcampos Dec 20, 2018

lcampos Dec 20, 2018

lcampos Dec 20, 2018

lcampos Dec 20, 2018

lcampos left a comment

salesforce-cla bot commented Jul 12, 2020

Easy Deploy on Save #822

Easy Deploy on Save #822

Conversation

allileong commented Dec 14, 2018 • edited by lcampos Loading

What does this PR do?

What issues does this PR fix or reference?

codecov bot commented Dec 15, 2018 • edited Loading

Codecov Report

Choose a reason for hiding this comment

allileong Dec 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lcampos Dec 19, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lcampos left a comment

Choose a reason for hiding this comment

salesforce-cla bot commented Jul 12, 2020

allileong commented Dec 14, 2018 •

edited by lcampos

Loading

codecov bot commented Dec 15, 2018 •

edited

Loading

allileong Dec 19, 2018 •

edited

Loading

lcampos Dec 19, 2018 •

edited

Loading