Adding timestamps to command executions in output… #780
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #780 +/- ##
===========================================
+ Coverage 72.71% 72.73% +0.02%
===========================================
Files 167 167
Lines 6772 6779 +7
Branches 1064 1065 +1
===========================================
+ Hits 4924 4931 +7
Misses 1582 1582
Partials 266 266
Continue to review full report at Codecov.
|
| @@ -79,6 +85,19 @@ export class ChannelService { | |||
| }); | |||
| } | |||
|
|
|||
| private getExecutionTime() { | |||
There was a problem hiding this comment.
Using the same time format as we're using in apex lsp and debug logs.
|
|
||
| execution.processExitSubject.subscribe(data => { | ||
| this.channel.append(execution.command.toCommand()); | ||
| this.channel.append( |
There was a problem hiding this comment.
I looked at having this as part of the classes in commandExecutor.ts, having an internal variable (per class) to track start and end of execution and then leverage them whenever we wanted to print them. It turned out to be more complex and un-intuitive in case we wanted to use those timestamps somewhere else other than for the output view.
I then turned to the simplest approach which is adding it here on the right execution methods. Let me know if I should look at moving this somewhere else where it makes more sense.
cc @vazexqi
lcampos
requested review from
vazexqi,
ntotten,
AnanyaJha,
allileong,
JimSuplizio and
praksb
lcampos
force-pushed
the
lcampos/timestamps-on-output-lines
branch
from
da0db58 to
11cec0c
Compare
lcampos
changed the title
lcampos
force-pushed
the
lcampos/timestamps-on-output-lines
branch
from
11cec0c to
0676a73
Compare
lcampos
force-pushed
the
lcampos/timestamps-on-output-lines
branch
from
0676a73 to
b83e73b
Compare
… view
What does this PR do?
Adds timestamps to every sfdx command execution that's being printed in the Output panel.
As the title suggests, this is a work in progress cause I want to run the automation and see if I missed any test failures and get feedback.
What issues does this PR fix or reference?
#759