Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Checkpoints by default #664

Merged
merged 3 commits into from
Oct 8, 2018
Merged

Enable Checkpoints by default #664

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aef4656
Enable Checkpoints by default
Oct 5, 2018
af34a16
Merge branch 'develop' into jsuplizio/EnableCheckpointsByDefault
Oct 7, 2018
c601898
Disable UI tests until we modify them for the XPath change in VS Code…
Oct 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/salesforcedx-vscode-apex-replay-debugger/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@
"properties": {
"salesforcedx-vscode-apex-replay-debugger-checkpoints.enabled": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't it be better to just remove this whole properties? That's what we did before after we are ready to GA something that was guarded.

Or, do you

  1. Think that is too risky?
  2. Envision that you might want to actually have some people be able to toggle between the two?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vazexqi we (the team) had talked about this in standup earlier this week. We decided that leaving the flag in, for the moment, was the way we wanted to handle this right now. We are ultimately going to remove this but with the current timeline this was the safest change.

"type": "boolean",
"default": false,
"default": true,
"description": "%replay-debugger_checkpoints_enabled%"
}
}
Expand Down