Fix lightning component syntax highlighting issues #637
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #637 +/- ##
===========================================
+ Coverage 74.96% 74.97% +0.01%
===========================================
Files 158 158
Lines 6236 6243 +7
Branches 968 970 +2
===========================================
+ Hits 4675 4681 +6
- Misses 1321 1322 +1
Partials 240 240
Continue to review full report at Codecov.
|
| { | ||
| "language": "html", | ||
| "scopeName": "text.html.basic", | ||
| "path": "./syntaxes/html.tmLanguage.json" |
There was a problem hiding this comment.
Is this scoped to just the above extensions or will it replace all html?
There was a problem hiding this comment.
Yes, it only applies to those file extensions.
|
Hmm... what license is this https://github.com/textmate/html.tmbundle/blob/master/README.mdown#license I don't recognize it. Could we check with our lawyers quickly @ntotten? |
| @@ -0,0 +1,746 @@ | |||
| { | |||
There was a problem hiding this comment.
Is this use completely as-is or did we have to modify some things? Asking to see if there is anything I need to focus on.
There was a problem hiding this comment.
I modified nothing about it, only took the previous version of it which doesn't contain the rules that check for invalid tags.
lcampos
force-pushed
the
lcampos/aura-tmLanguage
branch
from
2e69c47 to
e6c871e
Compare
What does this PR do?
Forks the previous version of the html syntax file (https://github.com/textmate/html.tmbundle) and includes it as part of the lightning extension.
What issues does this PR fix or reference?
#573