Update lwc-language-server to the latest version @W-5215984@ #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcampos
commented
Jul 19, 2018
| @@ -27,7 +27,7 @@ | |||
| "ajv": "^6.1.1", | |||
| "eslint": "4.16.0", | |||
| "eslint-plugin-lwc": "0.4.0", | |||
| "lwc-language-server": "1.6.3", | |||
| "lwc-language-server": "1.6.4", | |||
There was a problem hiding this comment.
Not sure if lwc-next should be on another version given it's a preview of what's coming in lwc.
rsalvador
approved these changes
Jul 19, 2018
Codecov Report
@@ Coverage Diff @@
## develop #532 +/- ##
========================================
Coverage 75.89% 75.89%
========================================
Files 146 146
Lines 5758 5758
Branches 900 900
========================================
Hits 4370 4370
Misses 1160 1160
Partials 228 228Continue to review full report at Codecov.
|
rsalvador
reviewed
Jul 19, 2018
| "eslint-plugin-lwc": "0.3.2", | ||
| "lwc-language-server": "1.5.1", | ||
| "eslint-plugin-lwc": "0.4.0", | ||
| "lwc-language-server": "1.6.4", |
There was a problem hiding this comment.
are you sure you want to upgrade this also?, 1.5.1 was for 214
There was a problem hiding this comment.
you are right, I'll revert this change.
jkalloor0701
pushed a commit
to jkalloor0701/salesforcedx-vscode
that referenced
this pull request
Aug 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates lwc & lwc-next extension to the latest language server version.
What issues does this PR fix or reference?
@W-5215984@