Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Go To Definition for class/interface usage sites for inner classes #258

Merged
merged 1 commit into from
Jan 16, 2018

Conversation

GaryFNC
Copy link
Contributor

@GaryFNC GaryFNC commented Jan 15, 2018

Checkin in the signed apex-jorje-lsp.jar for the type usage bug
fixes made in Apex LS

Added URI information on the source file being compiled to ensure that
the location can be found for inner classes and interfaces referenced
from the same file

Changed the matching algorithm on interfaces to handle type refs that
only give the stated name of an interface, not the full name (ex.
OuterClass.Interface1 while the type ref name is just Interface1).

Also this matching test must be case insensitive like Apex (user could type
interface1).

@W-4593425, W-4598183@

@GaryFNC GaryFNC requested review from vazexqi and lcampos January 15, 2018 18:48
@vazexqi
Copy link
Contributor

vazexqi commented Jan 15, 2018

@GaryFNC

@W-4593425@
@W-4598183@

doesn't work.

It needs to be @W-4593425, W-4598183@

@GaryFNC GaryFNC force-pushed the gary/typeusagebugs branch from ff0f842 to 5c4f47d Compare January 15, 2018 21:33
@codecov
Copy link

codecov bot commented Jan 15, 2018

Codecov Report

Merging #258 into develop will increase coverage by 6.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #258      +/-   ##
===========================================
+ Coverage     74.7%   80.83%   +6.13%     
===========================================
  Files          111      125      +14     
  Lines         4270     4765     +495     
  Branches       699      789      +90     
===========================================
+ Hits          3190     3852     +662     
+ Misses         906      748     -158     
+ Partials       174      165       -9
Impacted Files Coverage Δ
...cedx-vscode-core/src/commands/forceDebuggerStop.ts 77.27% <0%> (-14.62%) ⬇️
...forcedx-vscode-core/src/commands/forceOrgCreate.ts 79.16% <0%> (-11.31%) ⬇️
...edx-vscode-core/src/commands/forceProjectCreate.ts 64.15% <0%> (-9.77%) ⬇️
...orcedx-vscode-core/src/commands/forceSourcePull.ts 68.42% <0%> (-8.05%) ⬇️
...orcedx-vscode-core/src/commands/forceSourcePush.ts 70% <0%> (-7.78%) ⬇️
...orcedx-vscode-core/src/commands/forceConfigList.ts 83.33% <0%> (-7.58%) ⬇️
...forcedx-vscode-core/src/commands/forceAliasList.ts 83.33% <0%> (-7.58%) ⬇️
...rcedx-vscode-core/src/commands/forceApexTestRun.ts 83.78% <0%> (-7.4%) ⬇️
...cedx-vscode-core/src/commands/forceSourceStatus.ts 73.07% <0%> (-6.09%) ⬇️
...code-core/src/notifications/notificationService.ts 94.28% <0%> (-5.72%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a9d5e...5d3fd4e. Read the comment docs.

Checkin in the signed apex-jorje-lsp.jar for the type usage bug
fixes made in Apex LS

Added URI information on the source file being compiled to ensure that
the location can be found for inner classes and interfaces referenced
from the same file

Changed the matching algorithm on interfaces to handle type refs that
only give the stated name of an interface, not the full name (ex.
OuterClass.Interface1 while the type ref name is just Interface1).

Also this matching test must be case insensitive like Apex (user could type
interface1).

@W-4593425@
@W-4598183@
@GaryFNC GaryFNC force-pushed the gary/typeusagebugs branch from 5c4f47d to 5d3fd4e Compare January 16, 2018 00:43
@GaryFNC GaryFNC merged commit 758b60e into develop Jan 16, 2018
@vazexqi vazexqi deleted the gary/typeusagebugs branch April 3, 2018 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants