Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for getting execution errors from the CLI #2216

Merged
merged 1 commit into from
May 26, 2020

Conversation

lcampos
Copy link
Contributor

@lcampos lcampos commented May 26, 2020

What does this PR do?

Makes sure we return error info from a CLI execution. Old versions of the CLI used to return error info in stdError but newer versions return it in stdOut.

What issues does this PR fix or reference?

@W-7287990@, #2160 , #2005

@lcampos lcampos requested a review from a team as a code owner May 26, 2020 16:51
@codecov
Copy link

codecov bot commented May 26, 2020

Codecov Report

Merging #2216 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2216      +/-   ##
===========================================
- Coverage    74.06%   74.05%   -0.02%     
===========================================
  Files          234      234              
  Lines         8800     8800              
  Branches       986      986              
===========================================
- Hits          6518     6517       -1     
  Misses        2036     2036              
- Partials       246      247       +1     
Impacted Files Coverage Δ
...forcedx-vscode-core/src/channels/channelService.ts 83.72% <0.00%> (-2.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b98874...dc14324. Read the comment docs.

Copy link
Contributor

@xyc xyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to have some test changes accompanying this change

@lcampos lcampos merged commit 645048d into develop May 26, 2020
@lcampos lcampos deleted the lcampos/fix-apex-debugger-errors branch May 26, 2020 17:55
lcampos added a commit that referenced this pull request May 28, 2020
lcampos added a commit that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants