Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of Java 11 #1275

Merged
merged 2 commits into from
Apr 29, 2019
Merged

Allow use of Java 11 #1275

merged 2 commits into from
Apr 29, 2019

Conversation

lcampos
Copy link
Contributor

@lcampos lcampos commented Apr 22, 2019

What does this PR do?

Allow usage of Java 11 for Apex language server

What issues does this PR fix or reference?

if (stderr.indexOf('1.8') < 0) {
if (
stderr.indexOf('build 1.8') < 0 &&
stderr.indexOf('build 11.') < 0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using build 11. allows users to use either Java 11 or OpenJDK 11.

@codecov
Copy link

codecov bot commented Apr 22, 2019

Codecov Report

Merging #1275 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1275      +/-   ##
===========================================
- Coverage     72.8%   72.77%   -0.03%     
===========================================
  Files          202      202              
  Lines         7405     7406       +1     
  Branches       773      774       +1     
===========================================
- Hits          5391     5390       -1     
- Misses        1849     1850       +1     
- Partials       165      166       +1
Impacted Files Coverage Δ
...kages/salesforcedx-vscode-apex/src/requirements.ts 28.57% <0%> (-0.7%) ⬇️
...forcedx-vscode-core/src/channels/channelService.ts 83.33% <0%> (-2.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a814ad...f5380e9. Read the comment docs.

@praksb praksb merged commit c538b6f into develop Apr 29, 2019
@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Luis Campos <l***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants