-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow use of Java 11 #1275
Allow use of Java 11 #1275
Conversation
if (stderr.indexOf('1.8') < 0) { | ||
if ( | ||
stderr.indexOf('build 1.8') < 0 && | ||
stderr.indexOf('build 11.') < 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using build 11.
allows users to use either Java 11 or OpenJDK 11.
Codecov Report
@@ Coverage Diff @@
## develop #1275 +/- ##
===========================================
- Coverage 72.8% 72.77% -0.03%
===========================================
Files 202 202
Lines 7405 7406 +1
Branches 773 774 +1
===========================================
- Hits 5391 5390 -1
- Misses 1849 1850 +1
- Partials 165 166 +1
Continue to review full report at Codecov.
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Luis Campos <l***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request. |
What does this PR do?
Allow usage of Java 11 for Apex language server
What issues does this PR fix or reference?