Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated prettier doc to use latest prettier release #1264

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

ntotten
Copy link
Contributor

@ntotten ntotten commented Apr 15, 2019

What does this PR do?

Updates prettier doc to use latest prettier release.

@W-6058270@

@ntotten ntotten requested a review from lcampos April 15, 2019 14:54

1. Install the latest `master` branch of Prettier by running: `npm i prettier/prettier -D`
1. Install Prettier by running: `npm install --save-dev --save-exact prettier`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming it's because of the new LWC parser (https://prettier.io/blog/2019/04/12/1.17.0.html) ?

Copy link
Contributor Author

@ntotten ntotten Apr 17, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, previously it wasn't released so you had to install master.

@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #1264 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1264   +/-   ##
=======================================
  Coverage   70.98%   70.98%           
=======================================
  Files         196      196           
  Lines        7397     7397           
  Branches      781      781           
=======================================
  Hits         5251     5251           
  Misses       1990     1990           
  Partials      156      156

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51550f2...e49c63a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants